search

ananthbh / SurveyList

0 stars 0 forks source link

Regarding the design #8

Open teamdisc opened 6 years ago

teamdisc commented 6 years ago

Hi Ananth!

I'm Team from Nimbl3. Thanks for your code. Overall, it seems nice, but there's some point I'd like to point out. Feel free to comment back if you have any concern over my comment or you have your reason behind your implementation. ✌🏻

Firstly, we have some concern regarding the design. If we go into detail, the menu button looks a little too big and doesn't match with reload button's size. The status bar is left blank and, IMO, it looks a bit off. The image views aren't set its content mode as .scaleAspectToFit so their ratio aren't quite right.

ananthbh commented 6 years ago

Hi Thank you so much for the overall feedback. I am glad you found it nice.

Yes, It's true that the menu button is a bit bigger, I just overlooked that part, my bad. Regarding the imageView content mode, I have used AspectFill because my intention was more off to fill the screen with the imageview so that they look uniform. Just incase, if any image is small and takes only half the screen.