search

ananthbh / SurveyList

0 stars 0 forks source link

Regarding rxSwift and rxCocoa #9

Open teamdisc opened 6 years ago

teamdisc commented 6 years ago

rxSwift and rxCocoa are imported as pods in the project. I love that you have experience with reactive framework like this! But I have some concern that they are not fully used in some case. e.g. isFetchingSurveys property in SurveyPageViewController could be replaced with rx signal. If we bind it with the hud. I think it would look a little cleaner. ✌🏻

ananthbh commented 6 years ago

Thank you so much for the advice. Frankly, this is something which did not hit me when I am working on the project. It's really great idea and I'll keep it in mind.