search

anantzoid / Conditional-PixelCNN-decoder

Tensorflow implementation of Gated Conditional Pixel Convolutional Neural Network
485 stars 84 forks source link

Inconsistency with paper in connection from vstack to hstack #6

Open kkleidal opened 6 years ago

kkleidal commented 6 years ago

https://github.com/anantzoid/Conditional-PixelCNN-decoder/blob/9a5c9a3df2c58100cf5e3600392e67db8ac7a59e/models.py#L30-L34

This has the connection from the vstack to the hstack occuring after the gate, but in Figure 2 of the paper, it occurs after the masked convolution but before splitting the channels and gating. Any particular reason for this change?

falconjhc commented 5 years ago

Yeah I also found the issue. Is it the official code written by the original paper author?

kkleidal commented 5 years ago

Sidenote: Sorry for my previous comment (now deleted). I didn't read the email closely enough and thought it was in response to a similarly named repo I made.

I don't think this is the official implementation. I did try to correct the issue in #7 which has since been merged.

yuffon commented 5 years ago

In the original paper, the link from vstack to hstack is before gate. This code is different.

Raaaaaaat commented 4 years ago

I'm new to this paper, and I found that the hstack is different with the original paper. the code is"[filter_size if full_horizontal else 1, filter_size, conf.fmap]" and para "full_horizontal" is set as TRUE Cuz the size of mask is changging from 7x7 to 3x3, and perhaps the size of mask should be 1x7/1x3? I think the size of horizontal stack is changging from 1x3 to 1x7, but maybe I understand the wrong way, anyone can explain why the kernel changes from 7x7 to 3x3 and why it is 7x7 instead of 1x7? I'm so confused, plzplzplz help me out, I really appreciate your help! THX!!!!