search

anapnoe / stable-diffusion-webui-ux

Stable Diffusion web UI UX
GNU Affero General Public License v3.0
964 stars 60 forks source link

[Bug]: Applying any "Defaults" breaks custom themes #185

Closed tdtrumble closed 11 months ago

tdtrumble commented 1 year ago

Is there an existing issue for this?

What happened?

When using 'Defaults' menu in settings, changes to UI are always detected so trying to save any setting will update ui-config.css and break custom theming. As soon as new defaults are saved, UI will always load in as default theme.

You can still change it for the session, but I've found no way to fix this via the UI so it saves a selected theme.

When this occurs, I can delete ui-config.css from the main folder and relaunch, it will recreate the ui-config.css file using default and fix the custom theming behavior.

This basically renders the 'Defaults' saving functionality in settings useless.

Steps to reproduce the problem

  1. Go to Settings tab
  2. Go to 'Defaults'
  3. Hit 'View changes' to see it detect changes to: ui_theme/Vars/value and ui_theme/Css/value
  4. Hit 'Apply'
  5. Reload UI, change theme, as many times as you want and watch it always load defaults

What should have happened?

I suppose the correct fix would be to have Settings>Defaults ignore any detected changes to ui_theme/Vars/value and ui_theme/Css/value for this repo, that way the custom theming and persistency between sessions never gets overridden

Version or Commit where the problem happens

https://github.com/anapnoe/stable-diffusion-webui-ux/commit/b5de227b5389e877c61fd9079b590470d455c2cc

What Python version are you running on ?

Python 3.10.x

What platforms do you use to access the UI ?

Windows, Linux

What device are you running WebUI on?

Nvidia GPUs (RTX 20 above)

Cross attention optimization

Automatic

What browsers do you use to access the UI ?

Microsoft Edge

Command Line Arguments

n/a

List of extensions

n/a

Console logs

n/a

Additional information

No response

tdtrumble commented 11 months ago

Closing. I did a fresh install and can't get the theme to save between sessions. I have no idea what the "expected" behavior is so can't tell whats wrong.