search

anapnoe / stable-diffusion-webui-ux

Stable Diffusion web UI UX
GNU Affero General Public License v3.0
978 stars 59 forks source link

[Feature Request]: Coop with Kitchen WebUI Theme #76

Open bropines opened 1 year ago

bropines commented 1 year ago

Is there an existing issue for this?

What would your feature do ?

Cooperation with https://github.com/canisminor1990/sd-webui-kitchen-theme.

Proposed workflow

I noticed that some of the plugins from the original automatic work great with your version and the version from vladomatic, but for example your version kills the ability to make the ui beautiful (yes, all people have their own vision of beauty). I think we can cooperate and make a special module for customizing and improving webUI and distribute it among Automatic users, since its further work remains in doubt.

Additional information

No response

anapnoe commented 1 year ago

how does it kill it exactly there is an inbuild real-time theme configurator that you can adjust your theme and I am planning a dnd functionality for the blocks to be move around along with custom family icons to select from

bropines commented 1 year ago

how does it kill it exactly there is an inbuild real-time theme configurator that you can adjust your theme and I am planning a dnd functionality for the blocks to be move around along with custom family icons to select from

When you try to set the theme, everything specifically rides, which means that something interferes with it in your variation of the interface gradio. Can your gradio changes be made as a disabled component?

LoathingScreen commented 1 year ago

tbh kitchen theme sucks, it didn't even allow the 2 main sections to be resized, hell it has basically no customization at all. I switched from automatic1111 with kitchen to this one cause the UI is miles ahead. Getting it merged with vlad is all I wanted. If anything, let the kitchen theme ppl adapt to whats out there and not the other way around. This UI is the best there is

anapnoe commented 1 year ago

how does it kill it exactly there is an inbuild real-time theme configurator that you can adjust your theme and I am planning a dnd functionality for the blocks to be move around along with custom family icons to select from

When you try to set the theme, everything specifically rides, which means that something interferes with it in your variation of the interface gradio. Can your gradio changes be made as a disabled component?

it has its own theme engine that can be modified on the fly and it will not map to gradios vars cause they don't follow common practices guidelines like prefixes in their name vars etc, gradios theme engine uses 471 vars most of them generic while anapnoe-ui-ux uses 38 well defined ones and can be easily extended gradio theme engine uses only hex color mode while anapnoe-ui-ux supports hex, rgb, hsl color modes I have no reason to follow gradios innovations as they are bound to change completely in the next rewrite as they often say when they make staff that don't hold well so it was by choice to override gradios theme engine to optimize and have consistency between gradio version updates of course you can disable the inbuild theme configurator if you are happy with your theme

bropines commented 1 year ago

it has its own theme engine that can be modified on the fly and it will not map to gradios vars cause they don't follow common practices guidelines like prefixes in their name vars etc, gradios theme engine uses 471 vars most of them generic while anapnoe-ui-ux uses 38 well defined ones and can be easily extended gradio theme engine uses only hex color mode while anapnoe-ui-ux supports hex, rgb, hsl color modes I have no reason to follow gradios innovations as they are bound to change completely in the next rewrite as they often say when they make staff that don't hold well so it was by choice to override gradios theme engine to optimize and have consistency between gradio version updates of course you can disable the inbuild theme configurator if you are happy with your theme

I understand both of you. In general, your arguments are objective. Then I have an offer. As soon as you have time, make a wiki for all methods of customization management. The main problem of gradio is, as you said, complete chaos, and the developer of kitchen is stupidly engaged in reverse engineering so that it all cooes normally. The easier it is for third-party developers to improve the product, the better for the project.