search

anarcat / bup-cron

mirror of the bup-cron repository, may be out of date while i figure out github mirror things
https://gitlab.com/anarcat/bup-cron
GNU Affero General Public License v3.0
22 stars 4 forks source link

Issue with backing up "/" and bup's "--strip-path /" option #16

Open blueyed opened 9 years ago

blueyed commented 9 years ago

I've just noticed that backing up "/" appeared to strip off all paths of the first level.

This has been fixed in https://github.com/bup/bup/commit/1e6960cc99f293c740d6ab4c9f0bd4008f5626d2 - I don't know if it has regressed recently or has been like this for longer.

Maybe bup-cron could not use --strip-path when backing up /?

anarcat commented 9 years ago

oh boy, that old bug. i had tons of problems with --strip-path, but i thought they were all fixed. maybe it's because i just didn't notice the problem again.

i'm hesitant in adding workarounds for bup bugs in bup-cron. shouldn't we make people upgrade instead?

blueyed commented 9 years ago

i'm hesitant in adding workarounds for bup bugs in bup-cron. shouldn't we make people upgrade instead?

Agreed. But maybe a warning would be good, in case it's easy to detect this scenario.

blueyed commented 9 years ago

Maybe --strip-path could just be skipped if it's /?