search

anarcat / bup-cron

mirror of the bup-cron repository, may be out of date while i figure out github mirror things
https://gitlab.com/anarcat/bup-cron
GNU Affero General Public License v3.0
22 stars 4 forks source link

Do not skip saving for all "errors", e.g. "Permission denied" #8

Open blueyed opened 9 years ago

blueyed commented 9 years ago

bup save should not get skipped (always) when there are errors in bup index, because these might be irrelevant and should not prevent the whole backup from being saved, e.g.: read Linux attr: [Errno 13] Permission denied might happen when you've saved some file using sudo in $HOME (and you backup without using sudo).

blueyed commented 9 years ago

For some reason the file in question has odd permissions:

% ls -l ...
---------- 1 user user 21K Sep 16 13:45 /home/user/.local/share/vim/undo/...
anarcat commented 9 years ago

indeed. maybe we shouldn't skip save ever? or should we have a --force option?

blueyed commented 9 years ago

Yes, I would not skip it by default.

A config option like --dont-save-on-index-error (but shorter, and maybe more generic like --halt-on-errors) would be useful then though. Maybe in the same context something like "--skip-save", which would be useful when you want to test how much gets indexed, without saving.

anarcat commented 9 years ago

agreed. i am not even sure we need an option at all after all.