search

anarchuser / mic_stream

Flutter plugin to get an infinite audio stream from the microphone
https://pub.dev/packages/mic_stream
GNU General Public License v3.0
100 stars 68 forks source link

Fixed sampleRate settings to be adapted to Ios #61

Closed yama-yeah closed 1 year ago

yama-yeah commented 1 year ago

62

Modified code so that SampleRate can be changed. Since the ChangeLog has not been touched, please edit the ChangeLog if you want to incorporate this modification as a new version.

anarchuser commented 1 year ago

Hey, thank you for your work. I need a bit more time to look over the changes; I'll get back to you sometime this week. In the meantime, I'd like to ask you to please open an issue describing why you suggest this change. This helps me keep track of changes more easily. Lastly, feel free to add an entry to the Changelog for 0.6.5, that's what I will publish it as once I've had a look through the code.

yama-yeah commented 1 year ago

Thanks for the reply. After lunch I'll get to work!

yama-yeah commented 1 year ago

Thanks for the review. I have improved the style. It appears that if was set to two lines and else if was set to one line as a dart style setting in vscode. In the future, maybe there will be people like me who are pulled into the vscode settings and the if statement style will not be stable. I didn't have much time this time, so I dealt with it by turning off automatic formatting on save, but it might be better to let the repository define the formatting settings for you.

anarchuser commented 1 year ago

Sadly, I don't have the time to set things like autoformattung up. At some point in the future I want to clean up the whole project, but until then, I can only give basic support

anarchuser commented 1 year ago

I'll merge and publish it some time this week

anarchuser commented 1 year ago

Published as mic_stream: 0.6.5. Thanks for your contribution

rootux commented 1 year ago

Hey @yama-yeah - sorry for the late response - but I just tested this on the latest ios and it does not seems to work

yama-yeah commented 4 months ago

As shown here IOS does not guarantee a change in sampling rate.