Closed Abdevna closed 7 months ago
I am a little confused how this will fix the issue?
the error: TypeError: BaseOnsiteLLM.generate() got an unexpected keyword argument 'temperature', seems like a parameter issue in our BaseOnsiteLLM class in onesite_llm.py.
What was your diagnosis of the root of this problem, maybe that will help me understand better
@abhigya-sodani I provided code modifications that assumed the temperature argument should be accepted by the generate method. I overlooked the fact that the generate method of the BaseOnsiteLLM class in onesite_llm.py doesn't accept a temperature argument. To resolve that we can modify the generate method in the BaseOnsiteLLM class to accept the temperature argument, something like this:
def generate(self, prompt, max_len, temperature=1.0, **kwargs):
This can, I believe ensure that the generate
method can accept the temperature
argument when called.
This issue was closed by #366
Closes #353 Please check it @VictorOdede @abhigya-sodani