search

anarkila / DeveloperConsole

Developer Console for Unity
MIT License
36 stars 1 forks source link

[Feature Request] Arrow Down to go back while previous command cycling #6

Closed ndumais closed 1 year ago

ndumais commented 1 year ago

Would allow to go back if you go past the command you were looking for, expected behaviour in command line.

anarkila commented 1 year ago

Added https://github.com/anarkila/DeveloperConsole/commit/55c9aab31bdd6877acd26aec1e3370129923e5a2. Commit is currently in the Dev branch.

ndumais commented 1 year ago

I think it's missing the part where it handles/checks for ArrowDown keypresses?

ndumais commented 1 year ago

image

It should be more like, "Console Search Command (Reverse) Key" or go back or something. Not sure if the issue is at the level of the feature too, but I think it might be?

Anyways, pressing arrow down, on my end, wont go back to the previous searched command.

anarkila commented 1 year ago

Anyways, pressing arrow down, on my end, wont go back to the previous searched command.

Currently you have to first click Up Arrow and then you can use Down Arrow to go reverse direction. I believe this how Windows CMD and Linux terminal also does it.

This same key also fills from suggested commands if they are shown. So this key serves two purposes. I understand the naming is a bit odd. I'll try to find better naming for this.

ndumais commented 1 year ago

Ah okay, knowing that it makes more sense and mostly works. I don't mind the single key, but it seems that if you cycled previously and then autofill more than once, it will then also cycle afterwards which is a bit confusing, maybe splitting the keys or if autofill is used reset the check and only allow autofill?

ndumais commented 1 year ago

If there's both the check and the split keys, it could also allow to use Space for autofill, which I believe is pretty common in IDEs.