anarsoul / gnuitar

GNU General Public License v2.0
1 stars 1 forks source link

I ported tubeamp.c to LV2, but get only silence #3

Open djshaji opened 1 week ago

djshaji commented 1 week ago

I am (again) porting the GNUitar effects to LV2, and just finished tubeamp.c. But I get only silence when I run it.

I've only changed the following:

Everything else is the same, including various controls. It compiles and runs successfully, but outputs only silence.

Can you suggest anything else I am missing? I haven't changed anything else. I've just reassembled stuff to fit LV2 specifications.

The repo is here: https://github.com/djshaji/gnuitar-lv2-newport

Any help would be welcome.

Thanks

djshaji commented 1 week ago

Hi, the following lines in tubeamp.c cause silence when uncommented:

result = do_biquad(result, &params->bq_bass, curr_channel); result = do_biquad(result, &params->bq_middle, curr_channel); result = do_biquad(result, &params->bq_treble, curr_channel);

I've not changed anything related to tone controls. The values of tone_* variables are sane (same as in gnuitar)

Any idea what could be wrong?

anarsoul commented 1 week ago

Does it work in Gnuitar? If yes, you may be getting non-normalized samples in your lv2 plugin (i.e. sample is not in [0.0, 1.0] range.

Inspect the output for working and non-working cases