add !important support to float mixin #10

anasnakawa / bi-app-sass

writing bi-directional stylesheets in sass

anasnakawa.github.io/bi-app-sass/

MIT License

96 stars 15 forks source link

Closed zeroxme closed 9 years ago

zeroxme commented 9 years ago

Now it supports !important by passing $imp as a second optional argument to the mixin and it's backward compatible

zeroxme commented 9 years ago

@anasnakawa any updates?

anasnakawa commented 9 years ago

why your proposed pull request only affect float mixins, not the rest ?

why would I want to add support for the important only to floats ?

zeroxme commented 9 years ago

Because issue #10 was only about float

anasnakawa commented 9 years ago

Sorry, on github you could easily forget an open pull request, sometimes I wish github provide a mark as unread feature.

zeroxme commented 9 years ago

ok thanks, i'll try to work on other mixins as well.