codepathreview
commented
10 years ago :+1: excellent work, Anastasiya!!! A few notes after checking out the code:
- Great work on packaging the code correctly
- Great job on using your own Application class.
- Clean SearchPreferences class to handle all your settings filter, good job.
- Good job using Parcelable over Serializable (benefits)
- Good job using the ConnectivityManager to check for network availability and notifying user about failure
- Great job implementing UpdateSettingsFragment for filters.
- Good to see you construct your URL in the GoogleImageClient class
- Good to see you added Search using the action bar and correctly implemented sharing
- Good to see JSON deserializing logic in the Image object. (Consider adding null checks)
- Good job adding client side validations for Website filter.
- Good job showing ProgressBar while network operation is happening
- General comment: clean and modularized code, great job on that
Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.
Hi, my app is ready for review. Thanks, Anastasiya /cc @nesquena @thecodepath