anasteyshaq / Library

Project Library for educational purposes.
0 stars 0 forks source link

it shoud have been done with fluent api to avoid tough coupling between application core and implementation details #2

Open DGrudzynskyi opened 3 years ago

DGrudzynskyi commented 3 years ago

https://github.com/anasteyshaq/Library/blob/dd53ffbd691c3d5fd76bc339a601f542c2b682b5/Library.Data/Entities/PublicationAggregate/Publication.cs#L12

I've examined file Library.Data.csproj and it appears that you have a LOT of dependencies on infrastructural things, such as web hosting specific assemblies, data annotations, http-specific libs, e.t.c.

Even though you might not been using them, it still make a "possibility" for usage of these items in assembly, designed as domain core.

Therefore, not increasing current mark for lab. (It would be less than 22 if i had found it earlier)