search

anatawa12 / ForgeGradle-1.2

This is only for FG_1.2(for minecraft 1.7.10). Minecraft mod development framework used by Forge and FML for the gradle build system
GNU Lesser General Public License v2.1
77 stars 29 forks source link

Update Libraries and actions #128

Closed kadir1243 closed 1 year ago

kadir1243 commented 1 year ago

Update Compile Java version to 8 Replace deprecated things in gradle script Update gradle to 7.5.1 Remove custom regex library(replaced with java's regex) Update guava Replace a few guava calls Change xml.bind package class call(it is called as part of java ee, java ee deprecated in java 9, removed in java 11) Update actions versions(Closes #107) Reducted codes by using lambda's Change a lot of code to use diamond operator fix a few deprecation warnings about gradle 8

anatawa12 commented 1 year ago

and I've configured CI for PullReqs. please merge FG_1.2 of this repository to run ci dirt this pr.

kadir1243 commented 1 year ago

Can you review again ?

anatawa12 commented 1 year ago

It looks the error is caused by the apache compress. It looks because the Pack200 implementation of apache compress is copied from harmony, an old implementation of JDK, which is not written to be used as a library. (I'll file I filed a issue to apache compress: COMPRESS-627) Can you revert using Pack200 of apache compress? Forge doesn't support java 9/later, deletion in 11/14 is not a big problem.

https://github.com/apache/commons-compress/blob/4b9e5440520198743dc8c16753e25700c429e943/src/main/java/org/apache/commons/compress/java/util/jar/Pack200.java#L68

anatawa12 commented 1 year ago

Please do not use snapshot version of compress. we cannot add dependency repositories.

anatawa12 commented 1 year ago

Please do not use snapshot version of compress. we cannot add dependency repositories.

In addition, I think there's no reason to use apach compress's Pack200 immediately, to keep system simple, I want not to add Pack200Util. Please use java's one until newer apache compress is released to maven central.

kadir1243 commented 1 year ago

is it now better ? can you review now ?

anatawa12 commented 1 year ago

except one thing above, LGTM. Thank you very much.