Some mappings are missing

anatawa12 / ForgeGradle-1.2

This is only for FG_1.2(for minecraft 1.7.10). Minecraft mod development framework used by Forge and FML for the gradle build system

GNU Lesser General Public License v2.1

85 stars 36 forks source link

Some mappings are missing #207

Closed iocmet closed 5 months ago

iocmet commented 1 year ago

There is some mappings missing, for example func_145771_j that is pushOutOfBlocks

anatawa12 commented 1 year ago

I think it depends on the mapping version so declare to use mapping version you want to use in minecraft block.

iocmet commented 1 year ago

It not works though

anatawa12 commented 1 year ago

Which version of MCP are you using? AFAIK, default mapping version for Forge 1614 does not include func_145771_j => pushOutOfBlocks mapping and I don't know which version of MCP does include that mapping. In addition, you must re-setup workspace.

Due to lack of information on your issue, I assume that the issue is that func_145771_j is not renamed to pushOutOfBlocks and I think it's expected behavior.

If this is not true, please describe the following:

What's wrong.
Steps to reproduce (including versions of plugins)

iocmet commented 1 year ago

Which version of MCP are you using? AFAIK, default mapping version for Forge 1614 does not include func_145771_j => pushOutOfBlocks mapping and I don't know which version of MCP does include that mapping. In addition, you must re-setup workspace.

Due to lack of information on your issue, I assume that the issue is that func_145771_j is not renamed to pushOutOfBlocks and I think it's expected behavior.

If this is not true, please describe the following:

What's wrong.

Steps to reproduce (including versions of plugins)

What you mean by mcp version? anyway mcp 908 not includes this mappings though There is for 1.7.10, you can see here https://mcp.thiakil.com/

In forgeBin some methods and fields is not deobfuscated

Setup minimal forgegradle workspace and then try reference any of this in code (like entity.func_145781_i)

anatawa12 commented 1 year ago

What you mean by mcp version?

Sorry for not being clear. I mean mcp srg to mcp name mapping version. There are some stable versions and tons of snapshot versions.

https://maven.minecraftforge.net/de/oceanlabs/mcp/mcp_snapshot/maven-metadata.xml https://maven.minecraftforge.net/de/oceanlabs/mcp/mcp_stable/maven-metadata.xml

There is for 1.7.10, you can see here https://mcp.thiakil.com/

thank you for providingsource of the mapping but the site looks broken. it redirects Infinity (at least 20 times).

Regardless the website is alive or not, the reason why the method is not renamed must be that mapping version difference.

iocmet commented 1 year ago

Site works for me, try web proxy like https://www.croxyproxy.com/ or other browser But i tried set latest (12) and channel stable

anatawa12 commented 1 year ago

How about newer snapshot versions? Or the site might use their own original mapping.

anatawa12 commented 1 year ago

I confirmed the mapping is exists in stable_12 channel but it doesn't included in the forge 1614 default mappong version (IDK name of the default version).

Specifying mapping version you want to use in build.gradle with minecraft { mappings = "stable_12" } and re-running ./gradlew setupDevWorkspace should fix this problem.

anatawa12 commented 7 months ago

@iocmet Could you try minecraft { mappings = "stable_12" } and re-setup workspace?

I confirmed this works in my environment.

iocmet commented 5 months ago

Sorry for not responding, looks like it works fine with stable_12, i think it not worked for me before because i tried specify version and channel with mappingsChannel and mappingsVersion and customVersion and mappingsSet left unspecified, i can close issue i think