anatawa12 / ForgeGradle-2.3

This is only for FG_2.3(for minecraft 1.12.2). Minecraft mod development framework used by Forge and FML for the gradle build system
GNU Lesser General Public License v2.1
32 stars 9 forks source link

Windows `Cannot run program "git": CreateProcess error=2, The system cannot find the file specified` #102

Closed jredfox closed 6 months ago

jredfox commented 6 months ago

do not run git commands unless you plan to manually install them for the user


C:\Users\jredfox\Documents\dev\MDK>gradlew setupdecompworkspace eclipse
Downloading https://services.gradle.org/distributions/gradle-6.3-all.zip
.............10%..............20%..............30%..............40%..............50%..............60%.............70%..............80%..............90%..............100%

Welcome to Gradle 6.3!

Here are the highlights of this release:
 - Java 14 support
 - Improved error messages for unexpected failures

For more details see https://docs.gradle.org/6.3/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)

FAILURE: Build failed with an exception.

* Where:
Build file 'C:\Users\jredfox\Documents\dev\MDK\build.gradle.kts' line: 440

* What went wrong:
Cannot run program "git": CreateProcess error=2, The system cannot find the file specified
> CreateProcess error=2, The system cannot find the file specified

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.3/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 1m 43s

C:\Users\jredfox\Documents\dev\MDK>
anatawa12 commented 6 months ago

It looks you're trying to create mod but downloading this repository is not the correct way. This repository contains ForgeGradle, an Gradle plugin used by MDK and this is not MDK. You should download MDK and replace with this ForgeGradle.

https://github.com/anatawa12/ForgeGradle-2.3?tab=readme-ov-file#how-to-use-this-forgegradle-instead-of-official-forgegradle

jredfox commented 6 months ago

@anatawa12 that didn't really work either the only thing that works with eclipse is to download an older 1.12.2 MDK fallow the instructions

the instructions were confusing, unclear and completely missing the fact you have to have installed git which not most people want to do.

anatawa12 commented 6 months ago

The git is not required to run mdk (projects with forgegradle).

download an older 1.12.2 MDK fallow the instructions

it's is precondition. the document is for people already have some mod developing,. the README descrives how to replace, there is no document to create new mod yet.

anatawa12 commented 6 months ago

I have added How to create project with this ForgeGradle instead of official ForgeGradle to README

jredfox commented 6 months ago

@anatawa12 1.12.2 did not require git to use forge gradle. and I am confused on why you keep saying use ForgeGradle instead of ForgeGradle? you Mean anatawa12ForgeGradle?

however when I run the projects with your fixes it requires git so I am saying you need to download it for the user if it's not found in the path and set it to their enviorment path for the user so no admin is required or require admin and run the powershell command for them (windows)

anatawa12 commented 6 months ago

1.12.2 did not require git to use forge gradle.

Yes. and not require git to use this ForgeGradle.

I am confused on why you keep saying use ForgeGradle instead of ForgeGradle? you Mean anatawa12ForgeGradle?

I'm always saying "to use this (fork of) ForgeGradle instead of official ForgeGradle". Since both project is ForgeGradle, I'm distinguishing two with "official" and "this/my (fork of)".

however when I run the projects with your fixes it requires git

Could you show me the error message? The error message above looks mentioning the build.gradle.kts in this repository. It is not necessary to build this repository for developing your mod.

https://github.com/anatawa12/ForgeGradle-2.3/blob/837fb50e5d1e5f13c28fa773deee7ed3620ae106/build.gradle.kts#L440

jredfox commented 6 months ago

Unable to reproduce with Modifying only Forge's MDK with your plugin

Please fix the unclear readme on how to use this fix. Say Usage Download Forge MDK from their website then modify them with x and y. Also you edited the URL inside of the build.gradle yet you didn't put it in your instructions. it's just confusing to me. The average coder even would assume this project that has releases is the actual replacement for Forge MDK and download this instead.