anatawa12 / ForgeGradle-2.3

This is only for FG_2.3(for minecraft 1.12.2). Minecraft mod development framework used by Forge and FML for the gradle build system
GNU Lesser General Public License v2.1
32 stars 9 forks source link

`deobfCompile` Does Not Work With Curse Maven #99

Closed Desoroxxx closed 1 year ago

Desoroxxx commented 1 year ago

When using Curse Maven with deobfCompile the dependencies just does not appear.

Sample code:

repositories {
    maven {
        name 'Curse Maven'
        url "https://cursemaven.com"
        content {
            includeGroup "curse.maven"
        }
    }
}

dependencies {
    deobfCompile 'curse.maven:LLibrary-243298:2504999'
    deobfCompile 'curse.maven:MowziesMobs-250498:3048685'

    deobfCompile 'curse.maven:ElenaiDodge2-442962:3343308'
}

This code will run, it seems to download the dependencies, the task won't fail, the dependencies just won't appear.

Hope this can be fixed!

ACGaming commented 1 year ago

This may specifically target more recent Gradle versions, as this works just fine under Gradle 4.

anatawa12 commented 1 year ago

Can you show me the output of dependencies task?

Desoroxxx commented 1 year ago

Can you show me the output of dependencies task?

https://mclo.gs/54ZPBe1

With --warning-mode all:

https://mclo.gs/a0s19Rc

Desoroxxx commented 1 year ago

This may specifically target more recent Gradle versions, as this works just fine under Gradle 4.

Indeed, that fixes it will work as a workaround for now, I hope this can be fixed soon

anatawa12 commented 1 year ago

Thank you for providing log. Did you run setup task after adding deobfCompile?

Desoroxxx commented 1 year ago

Thank you for providing log. Did you run setup task after adding deobfCompile?

If you mean setupDecompWorkspace yes

anatawa12 commented 1 year ago

Thank you for information. I found the reason of this bug. Since Gradle 5.0, Gradle requires pom for maven repository by default but the generated repository for deobfCompile doesn't provide pom. That's why deobfuscated dependencies does not apper. I'm fixing now.

anatawa12 commented 1 year ago

I've released & published ForgeGradle 2.3-1.0.8, which includes this fix.