search

anathema / anathema_legacy

Anathema is an exhaustive suite for all aspects of Exalted series management. This repository hold the code to support Exalted 1, Exalted 2 and Exalted 2.5.
http://anathema.github.com
69 stars 70 forks source link

Many Martial Arts Charms have incorrect prerequisites #189

Open Caveat-zz opened 12 years ago

Caveat-zz commented 12 years ago

Many of the Martial Arts Styles have a required Ability or other trait that is not listed in the prerequisites of the individual Charms. For example, to practice Crystal Chameleon Style an Exalt requires three dots assigned among Athletics & Stealth. The entry Charm(s) of these Styles should have these prerequisites added.

Celestial Monkey Style... No Virtue over 3. Crystal Chameleon Style... Three dots among Athletics & Stealth. Dreaming Pearl Courtesan Style... Performance, Presence, or Socialize x2. Hungry Ghost Style... Necromancy or a non-Martial Arts Ability Specialty involving ghosts or the underworld. Lunar Hero Style... Lunars require Dexterity instead of Martial Arts, others require Martial Arts as normal.

UrsKR commented 12 years ago

@Caveat, this feels like a bulk report, my first pick ("Art of Forceful Declaration") actually enforced the minimum you mentioned. Please check which of the styles actually are in error, and only mention those. Correction: It actually enforces a Valor minimum. Please check if it is the right one.

Caveat-zz commented 12 years ago

The following Martial Arts Styles are missing some of their non-Martial Arts Ability prerequisites: Celestial Monkey Style... No Virtue over 3. Crystal Chameleon Style... Three dots among Athletics & Stealth. Dreaming Pearl Courtesan Style... Performance, Presence, or Socialize x2. Hungry Ghost Style... Necromancy or any Specialty in either ghosts or the underworld. Lunar Hero Style... Lunars require Dexterity instead of Martial Arts, others require Martial Arts as normal.

UrsKR commented 12 years ago

So, we have 5 different types of prerequisites, none of them supported by our current code:

  1. A maximum value
  2. A number of dots spend across two traits
  3. One out of many traits at a minimum value
  4. A specialty with a given text (or) another Charm
  5. One trait for a given character type, another trait for all the others.

It's not important to me, but maybe someone else cares. Let's leave this open for a moment and wait for comments.

Caveat-zz commented 12 years ago

Lunar Hero Style: As I mentioned in the ticket about Lunar Hero Style's prerequisites; We already have the ability to filter which Charms are displayed in a cascade based on Exalt type. All we have to do to fix Lunar Hero Style is cut & paste every Charm in the current cascade & filter which "tree" in the cascade is displayed based on your Exalt type.

Celestial Monkey Style: Having a maximum value does not sound so complicated. I am against dismissing this. The least we can do is add a tooltip.

Crystal Chameleon Style: We have the code to have a minimum spread across Traits. This code is used by Lunars on their Ability tab (they have to have dots in any one of several Abilities).

Dreaming Pearl Courtesan Style: If we code the Crystal Chameleon Style requirement correctly we can use the same code here.

Hungry Ghost Style: I've elsewhere voiced my displeasure about the way Backgrounds & Specialties are handled. This seems like a more fundamental issue to me, though I seem to be on my own in that perspective.

If we are going to leave this open for a while... If this is seen as being five different issues, maybe I should close this ticket & make a different one for each cascade's error. Thoughts on that?

smattox commented 12 years ago

Martial Arts does seem to love these PITA one-off weird rules.

I'd prefer to just note all of the above as unsupported rules and leave it at that.

Caveat-zz commented 12 years ago

Dark Messiah Style: Instead of coding some weird modal prerequisite this one can be solved through a single line of data entry. Since we can have tooltip data say whatever we want, we should really change the beginning Charm to have a tooltip reminding the player of the modal prerequisite. I am totally on board with not bothering to make the code. Having a modal Charm-or-Specialty requirement is a lot more work than we need to worry about right now.

The fix for Lunar Hero Style is also just simple data entry, though the data entry needed is a little more. Here's how we use the existing code to make this bit work:

1: Apply a filter so only Lunars see the current (Dexterity) Charms of Lunar Hero Style. 2: Copy each Charm; on each copy change the prerequisite from Dexterity to Martial Arts. 3: Apply a filter so only non-Lunars see the duplicated (Martial Arts) Charms.

Celestial Monkey Style, Crystal Chameleon Style, & Dreaming Pearl Courtesan Style: This can be satisfied through data entry on the tooltip, just to remind the user, just like with Dark Messiah Style. As far as the future? I would like to advocate adding support for prerequisite Maximums & modal prerequisites because this is something that may come in handy when we make the switch to 3rd edition.

UrsKR commented 12 years ago

"No rules in the description" was our decision, and I'd like to stick to it. I'd take a patch for everything else.

As for 3rd Edition, let's cross that bridge when we come to it.