anathema / anathema_legacy

Anathema is an exhaustive suite for all aspects of Exalted series management. This repository hold the code to support Exalted 1, Exalted 2 and Exalted 2.5.
http://anathema.github.com
69 stars 70 forks source link

Suggestion: Comprehensive clean-up of all Charms #212

Open Caveat-zz opened 12 years ago

Caveat-zz commented 12 years ago

There are a lot of weird outliers in the Charm database, mostly because they were entered before we had the technology to support aspects of said Charms. For example: Charms that have repurchases being displayed multiple times, once for each repurchase. Another example: The Charm Peerless Paragon of (specific Craft Ability) would be best rendered using a drop-down box similar to Phoenix Renewal Tactic, but is instead rendered in the Solar Craft cascade as a large number of different Charms that take up a HUGE amount of space on the same line. (The Solar Integrity Charm Epic Zeal of (Virtue) could benefit from a similar drop-down box, as well.) There are also a number of outright errors in the Charm database (such as Five-Dragon Horseman Prana, which is in the database as five Elemental Charms even though the Charm's description says that isn't the case - the Charm can only be purchased once).

If this is an issue that we want to address someone will have to go through every single cascade & make a list of all of the modal Charms, all of the repurchase Charms, & point out general errors & inconsistencies. That would be a decent amount of boring work, but I'm willing to help out by going the slogging myself. If you guys are willing to make the corrections I'm willing to go slog through the database & make such a list of inconsistencies & errors.

Are there any things that the team would like me to specifically look for? Is this something that is worth me even investing the time to do in a complete & comprehensive way? Input appreciated.

smattox commented 12 years ago

This is definitely something that is desirable, and if you're willing to go through and find what needs to be corrected, that would be appreciated. Rather than just listing the problems off to us, though, what I would suggest is that you get set up with your own branch and learn how our charm data XML works, so you can make adjustments directly and just issue pull requests when you're done. Once you're set up to go, I'd expect that would save some headaches for all involved. :)

UrsKR commented 12 years ago

I fully agree with @JMobius. It's a worthwhile goal, but doing it in a two-step-process seems weird.

Caveat-zz commented 12 years ago

@JMobius & @UrsKR I'm slogging through setting stuff up, though I may not have time to actually do anything productive over the weekend.

UrsKR commented 12 years ago

Let us know about your main issues with setting up afterwards, maybe we can do something to improve in those areas.

smattox commented 12 years ago

I had some difficulty getting set up, initially, but the problems were all related to getting Git working. Anathema itself is pretty straightforward once you get to it. :)