Application Menu, File Menu bugs

[Tenacious-Techhunter]

On the OS X version of Anathema, the following bugs occur...

The Application menu is titled “Anathema”, which is most likely intended to be the correct name; but when you click on it, everywhere within the menu that SHOULD say “Anathema” (assuming that’s correct, and it probably is), instead says “AnathemaBootLoader” (no spaces). The “Preferences” menu item is mysteriously absent, even though that’s where it belongs under OS X HIGs. The “File” menu has both “Preferences” and a duplicate of “Quit”, in spite of those being the incorrect locations for those things, according to OS X HIGs.

Someone needs to update your NIB file.

[UrsKR]

You're right, it seems to display the main class name instead of the application name.

Long story short, we don't even have a .nib file, because Anathema isn't a native OS X application. We never cared much about OS specifics outside of Windows, because we did not have access to OS X until recently.

Depending on Apple's stance here these things could be easily remedied - if they are simple configurables - or beyond our reach - if they require a fee to Apple.

@curttasker, do you know if we can do something about this issue?

[UrsKR]

Should be possible, this looks helpful. I assume the simplest approach would be a launcher separate from AnathemaBootLauncher, one that configures the Mac specifics and then launches Anathema as usual.

[curttasker]

As @UrsKR mentions, we don't use nib/xib files, because this is a pure java program. We're currently using some of Oracle/Apple's tools to package the code inside a an application bundle. There's a bits of code in Anathema to handle attempting to store repository files in something resembling the proper location, basic menubar stuff, etc.

Little issues like this tend to go unfixed, mainly because nobody ever reports them. We break so many of the OSX HIGs due to being a multiplatform java program that we could spend months spinning our wheels trying to find and fix them all. If we ever go down that rabbit hole, I have much graver concerns than the correct labeling and placement of items on the menubar.

That said, I have been meaning to take a look at the menubar code to fix the broken accelerators (they've stopped working in the past year, I suspect during the partial JavaFX conversion). I'll see how much of this I can clean it up.

[Tenacious-Techhunter]

Let’s put it this way... from an HIG perspective, the menu bar is important, and the rest, not so much. You’ve got a non-standard application dealing with very non-standard issues; so long as you aren’t using a system feature, good interface design trumps HIGs. The Menu bar, however, IS a system feature, and so you should be compliant there.

The only other place where I see bad behavior is when you have a popup, and a bug popup gets generated; it tends to get “hidden” toward the back. I’ll post a bug about it when I encounter it again, so I can give you specifics.

[UrsKR]

I'm with you on this one, @Tenacious-Techhunter. Integrating with the OS but doing it in a crooked way is bad style.

I'd like to fix it, but it's not all-important to me at this moment, as I have a huge ongoing project in #334. Even more so since part of the solution to this issue may be overridden by that issue.