search

anathema / anathema_legacy

Anathema is an exhaustive suite for all aspects of Exalted series management. This repository hold the code to support Exalted 1, Exalted 2 and Exalted 2.5.
http://anathema.github.com
69 stars 70 forks source link

Update Anathema to Java 8 #364

Closed UrsKR closed 10 years ago

UrsKR commented 10 years ago

I have spent some time updating Anathema to Java 8, and would like to merge the changes back to master. @curttasker, @smattox, are we in agreement that updating is a good move?

Right now, the one thing keeping me is that the latest build of MigLayout is not yet available in any public maven repo. I have already sent @mikaelgrev a message asking if he would put it there.

smattox commented 10 years ago

Sounds good to me.

Did you isolate the source of the slowdown?

-Sean

On Sat, Apr 19, 2014 at 10:00 AM, Urs Reupke notifications@github.comwrote:

I have spent some time updating Anathema to Java 8, and would like to merge the changes back to master. @curttasker https://github.com/curttasker, @smattoxhttps://github.com/smattox, are we in agreement that updating is a good move?

Right now, the one thing keeping me is that the latest build of MigLayout is not yet available in any public maven repo. I have already sent @mikaelgrev https://github.com/mikaelgrev a message asking if he would

put it there.

You can merge this Pull Request by running

git pull https://github.com/anathema/anathema java8

Or view, comment on, or merge it at:

https://github.com/anathema/anathema/pull/364 Commit Summary

  • Runs on Java 8 / JavaFX 8. This makes Anathema run appallingly slow, so a profiler run is next.
  • Restores Exception dialog removed in 3d57baffca193e409144023ef9a82d27dfbd8803
  • Updates main build file to Java 8. Not yet on the server.
  • Migrates Character creation to ControlsFX Dialog framework
  • Removes icons associated with deprecated dialog
  • Migrates About Dialog to ControlsFX
  • Restores the ability to calculate a text's visual bounds.
  • Fixes an NPE in Text Areas under JavaFX 8.
  • Corrects layout in Charm view
  • Updates remnants of Swing to MigLayout 5.0-SNAPSHOT for consistency
  • Workaround for JavaFX issues RT-36728 and RT-36729
  • Workaround for JavaFX issues RT-36728 and RT-36729
  • Workaround for JavaFX issues RT-36728 and RT-36729
  • Workaround for JavaFX issues RT-36728 and RT-36729
  • Merge branch 'java8' of github.com:anathema/anathema into java8
  • Updates Dot value selection for JavaFX 8

File Changes

  • M Anathema/src/main/java/net/sf/anathema/AnathemaBootLoader.javahttps://github.com/anathema/anathema/pull/364/files#diff-0(37)
  • M Character_Equipment/src/main/java/net/sf/anathema/character/equipment/item/view/fx/FxCostSelectionView.javahttps://github.com/anathema/anathema/pull/364/files#diff-1(3)
  • M Character_Main/src/main/java/net/sf/anathema/hero/creation/CharacterCreationPresenter.javahttps://github.com/anathema/anathema/pull/364/files#diff-2(14)
  • M Character_Main_FX/src/main/java/net/sf/anathema/fx/hero/configurableview/FxConfigurableView.javahttps://github.com/anathema/anathema/pull/364/files#diff-3(2)
  • M Character_Main_FX/src/main/java/net/sf/anathema/fx/hero/configurableview/IntegerSpinner.javahttps://github.com/anathema/anathema/pull/364/files#diff-4(2)
  • A Character_Main_FX/src/main/java/net/sf/anathema/fx/hero/creation/ConfigurableControlsFxAction.javahttps://github.com/anathema/anathema/pull/364/files#diff-5(22)
  • A Character_Main_FX/src/main/java/net/sf/anathema/fx/hero/creation/ControlsFxTool.javahttps://github.com/anathema/anathema/pull/364/files#diff-6(68)
  • M Character_Main_FX/src/main/java/net/sf/anathema/fx/hero/creation/FxCharacterCreationView.javahttps://github.com/anathema/anathema/pull/364/files#diff-7(29)
  • M Character_Main_FX/src/main/java/net/sf/anathema/fx/hero/traitview/FxConfigurableLayout.javahttps://github.com/anathema/anathema/pull/364/files#diff-8(7)
  • M Character_Main_FX/src/main/java/net/sf/anathema/fx/hero/traitview/FxExtensibleTraitView.javahttps://github.com/anathema/anathema/pull/364/files#diff-9(16)
  • M Hero_Charms/src/main/java/net/sf/anathema/hero/charms/display/tree/CascadePresenter.javahttps://github.com/anathema/anathema/pull/364/files#diff-10(5)
  • M Hero_Charms/src/main/java/net/sf/anathema/hero/charms/display/view/CharmView.javahttps://github.com/anathema/anathema/pull/364/files#diff-11(2)
  • M Hero_Charms/src/main/java/net/sf/anathema/hero/charms/display/view/FxCharmView.javahttps://github.com/anathema/anathema/pull/364/files#diff-12(33)
  • M Hero_Languages/src/main/java/net/sf/anathema/hero/languages/display/view/FxSelectionViewWithTool.javahttps://github.com/anathema/anathema/pull/364/files#diff-13(3)
  • M Hero_Specialties/src/main/java/net/sf/anathema/hero/specialties/display/view/FxSpecialtyCreationView.javahttps://github.com/anathema/anathema/pull/364/files#diff-14(3)
  • M Namegenerator/build.gradlehttps://github.com/anathema/anathema/pull/364/files#diff-15(1)
  • D Namegenerator/src/main/java/net/sf/anathema/namegenerator/CategorizedNamegeneratorPresenter.javahttps://github.com/anathema/anathema/pull/364/files#diff-16(64)
  • D Namegenerator/src/main/java/net/sf/anathema/namegenerator/PresentedCategorizedNameGenerator.javahttps://github.com/anathema/anathema/pull/364/files#diff-17(54)
  • D Namegenerator/src/main/java/net/sf/anathema/namegenerator/view/category/CategorizedNameGeneratorView.javahttps://github.com/anathema/anathema/pull/364/files#diff-18(40)
  • D Namegenerator/src/main/java/net/sf/anathema/namegenerator/view/category/ICategorizedNameGeneratorView.javahttps://github.com/anathema/anathema/pull/364/files#diff-19(12)
  • M Platform/build.gradlehttps://github.com/anathema/anathema/pull/364/files#diff-20(2)
  • M Platform/src/main/java/net/sf/anathema/lib/workflow/textualdescription/SimpleTextualDescription.javahttps://github.com/anathema/anathema/pull/364/files#diff-21(3)
  • M Platform/src/main/resources/data/language/platform/anathema.propertieshttps://github.com/anathema/anathema/pull/364/files#diff-22(2)
  • A Platform/src/test/java/net/sf/anathema/lib/workflow/textualdescription/SimpleTextualDescriptionTest.javahttps://github.com/anathema/anathema/pull/364/files#diff-23(14)
  • M Platform_FX/build.gradlehttps://github.com/anathema/anathema/pull/364/files#diff-24(8)
  • D Platform_FX/src/main/java/net/sf/anathema/framework/fx/Dialog.javahttps://github.com/anathema/anathema/pull/364/files#diff-25(520)
  • M Platform_FX/src/main/java/net/sf/anathema/framework/fx/FxDialogExceptionHandler.javahttps://github.com/anathema/anathema/pull/364/files#diff-26(17)
  • M Platform_FX/src/main/java/net/sf/anathema/framework/presenter/action/about/AnathemaAboutAction.javahttps://github.com/anathema/anathema/pull/364/files#diff-27(53)
  • M Platform_FX/src/main/java/net/sf/anathema/platform/fx/dot/DotSelectionSpinner.javahttps://github.com/anathema/anathema/pull/364/files#diff-28(2)
  • M Platform_FX/src/main/java/net/sf/anathema/platform/fx/dot/DotSelectionSpinnerSkin.javahttps://github.com/anathema/anathema/pull/364/files#diff-29(30)
  • M Platform_FX/src/main/java/net/sf/anathema/platform/fx/selection/ComboBoxSelectionView.javahttps://github.com/anathema/anathema/pull/364/files#diff-30(7)
  • D Platform_FX/src/main/resources/icons/dialog/bugIcon.pnghttps://github.com/anathema/anathema/pull/364/files#diff-31(0)
  • D Platform_FX/src/main/resources/icons/dialog/confirmationIcon.pnghttps://github.com/anathema/anathema/pull/364/files#diff-32(0)
  • D Platform_FX/src/main/resources/icons/dialog/errorIcon.pnghttps://github.com/anathema/anathema/pull/364/files#diff-33(0)
  • D Platform_FX/src/main/resources/icons/dialog/infoIcon.pnghttps://github.com/anathema/anathema/pull/364/files#diff-34(0)
  • D Platform_FX/src/main/resources/icons/dialog/warningIcon.pnghttps://github.com/anathema/anathema/pull/364/files#diff-35(0)
  • M Platform_Swing/build.gradlehttps://github.com/anathema/anathema/pull/364/files#diff-36(2)
  • M Platform_TreeFx/src/main/java/com/sun/javafx/scene/control/skin/FxFontUtils.javahttps://github.com/anathema/anathema/pull/364/files#diff-37(15)
  • M build.gradlehttps://github.com/anathema/anathema/pull/364/files#diff-38(10)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/anathema/anathema/pull/364 .

UrsKR commented 10 years ago

Mikael fixed it. Apparently, the JavaFX implementation of MigLayout wasn't talking to the JavaFX-API in the way it expected to be spoken to.

In our discussion, Mikael made an aside about it, and I didn't think much of it - at that point, I expected the fault to lie somewhere in our code. Imagine my surprise when I woke up two days later, randomly checked the commits to MigLayout and saw him working all over the place! I pulled and built that version, and all the lag was gone.

curttasker commented 10 years ago

Updating the main branch at this time seems like a good plan.

On Sat, Apr 19, 2014 at 10:12 AM, Urs Reupke notifications@github.comwrote:

Mikael fixed it. Apparently, the JavaFX implementation of MigLayout wasn't talking to the JavaFX-API in the way it expected to be spoken to.

In our discussion, Mikael made an aside about it, and I didn't think much of it - at that point, I expected the fault to lie somewhere in our code. Imagine my surprise when I woke up two days later, randomly checked the commits to MigLayout and saw him working all over the place! I pulled and built that version, and all the lag was gone.

— Reply to this email directly or view it on GitHubhttps://github.com/anathema/anathema/pull/364#issuecomment-40874921 .