search

anathema / anathema_legacy

Anathema is an exhaustive suite for all aspects of Exalted series management. This repository hold the code to support Exalted 1, Exalted 2 and Exalted 2.5.
http://anathema.github.com
69 stars 70 forks source link

Fix rendering of Solar Melee Charm tree #41

Closed UrsKR closed 12 years ago

UrsKR commented 12 years ago

@the-smith reports: there's something not right with the code that displays the charm trees. Take a look at Solar Melee: at least for me, the 4th row of charms where Thousand Arms Prana appears, followed by Sun-Sword Concentration, etc, is way offset to the right, making the whole thing hard to use even on a 24" monitor.

UrsKR commented 12 years ago

In 2.0.1/2.0.2, the tree still looks OK. Not perfect, but way better.

smattox commented 12 years ago

I've traced the core of this problem to the removal of the Melee Excellency prerequisite for Dipping Swallow Defense. Adding it back restores the 2.0 behavior.

This change was originally made in commit ba3b83d1429f1ab38a72d2cbc51d3219b41d3455, made by Scott, apparently to co-align with the Dawn solution errata. According to the Exalted Wiki, Dipping Swallow Defense still requires an Excellency. I'd assume Scott's change is accurate, but if so we're going to need to figure out some solution in our graph drawing algorithms. An unpleasant prospect...

the-smith commented 12 years ago

On Fri, 17 Feb 2012 14:42:17 -0800 Sean Mattox reply@reply.github.com wrote:

I've traced the core of this problem to the removal of the Melee Excellency prerequisite for Dipping Swallow Defense. Adding it back restores the 2.0 behavior.

This change was originally made in commit ba3b83d1429f1ab38a72d2cbc51d3219b41d3455, made by Scott, apparently to co-align with the Dawn solution errata. According to the Exalted Wiki, Dipping Swallow Defense still requires an Excellency. I'd assume Scott's change is accurate, but if so we're going to need to figure out some solution in our graph drawing algorithms. An unpleasant prospect...

The Wiki's out of date, the change is in the Scroll of Errata,

currently on page 19.

            Scott
UrsKR commented 12 years ago

There are some more broken graphs in addition to Solar Melee:

Also affected, if only slightly (could be a good cases for analysis):

UrsKR commented 12 years ago

@vestrial and I spent a day honing the charm visualization, and where successful enough for us to consider this fixed. Relevant commits are 92eaaf09d31d7a1be0cffd5f304eeb8f7e181905 to 65e462bad9e957f6db4203a4011e9268836159a4.