anatine / zod-plugins

Plugins and utilities for Zod
640 stars 89 forks source link

More complete OpenAPI 3.1 support in `zod-openapi`. #173

Closed A5rocks closed 6 months ago

A5rocks commented 10 months ago

Split off from https://github.com/anatine/zod-plugins/pull/130.

nx-cloud[bot] commented 10 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 89578a79b8919398134fe575b0ccfc0fbcfe82a2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets - [`nx affected:test --base=origin/main --codeCoverage`](https://cloud.nx.app/runs/8uFMvcK3xt) - [`nx affected:lint --base=origin/main`](https://cloud.nx.app/runs/fRIsSC2rPz)

Sent with 💌 from NxCloud.

Brian-McBride commented 8 months ago

@A5rocks Can you resolve the conflicts here?

nx-cloud[bot] commented 8 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6fdba79bdcb7905b5883413338059dc5bef02f60. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets - [`nx affected:test --base=origin/main --codeCoverage`](https://cloud.nx.app/runs/PrXbl1EtEd?utm_source=pull-request&utm_medium=comment) - [`nx affected:lint --base=origin/main`](https://cloud.nx.app/runs/amKSTURmYw?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

A5rocks commented 8 months ago

Alright, conflicts should now be fixed!

RobbyUitbeijerse commented 7 months ago

hey there! @Brian-McBride / @erkstruwe , this looks rather ready and exactly what our team is looking for. Any chance this could be merged & released? We would love the 3.1 support to reference other Zod schemas, like generated Zod enums coming from https://www.npmjs.com/package/ts-to-zod , in manually created schemas. That currently doesn't work due to the missing $ref/3.1 support, but would greatly improve the output of the DTOs

lewinskimaciej commented 6 months ago

Up, anything we can do to get this pushed out?

nikelborm commented 6 months ago

@lewinskimaciej Probably resolve merge conflicts?

Brian-McBride commented 6 months ago

Yes, please resolve then the CI/CD can deploy.

A5rocks commented 6 months ago

Hmm, CI failure doesn't look like my fault. Tests seem to pass, at least.

nikelborm commented 6 months ago

Hmm, CI failure doesn't look like my fault. Tests seem to pass, at least.

There is one failing: https://github.com/anatine/zod-plugins/actions/runs/8350755969/job/22857844183?pr=173#step:7:96

A5rocks commented 6 months ago

Oops, I didn't notice that! Thought the red highlighted line was during setup so only looked after that...

nikelborm commented 6 months ago

I think repo owners or maintainers have to configure problem-matchers for this github action to highlight failed test cases

nikelborm commented 6 months ago

Yay! 🎉

lewinskimaciej commented 6 months ago

Nice, thank you guys! ❤️