search

anatol / quarry

Rubygems binary repository for Arch Linux
GNU General Public License v3.0
53 stars 25 forks source link

Misc. fixes #74

Closed eli-schwartz closed 6 years ago

eli-schwartz commented 7 years ago

Mainly inspired by trying to see if I could get this building smoothly on i686. I got irritated at having to build duplicates (and it messed around with my CacheDir in ways I didn't like), so I implemented filtering of packages that already exist in the official repos. :) I also couldn't help but notice you were technically running a partial update at one point. :p If the base chroot is persistent this can cause serious issues and there certainly is no harm in doing the right thing anyway...

anatol commented 7 years ago

Thank you for this PR. I pushed 2 of your commits. I still reviewing 3rd I just need a bit of time to refresh memory for that code.

eli-schwartz commented 7 years ago

I've rebased to add --noconfirm to that commit.

eli-schwartz commented 6 years ago

Force-pushed fixes that I think cover everything you suggested.

I ran quarry for a bit and it seems to be correctly filtering out repo packages. I also ran the cleanup on a copy of your quarry db, and it suggested to drop a bunch of repo packages.

eli-schwartz commented 6 years ago

Okay, the current version uses nicer looking variables too.

anatol commented 6 years ago

$FOO is a global variable. It is better to use an instance variable instead. I did it here https://github.com/anatol/quarry/commit/e5ea629a526fe8ffb6cffb11ffe58732f75adb17

eli-schwartz commented 6 years ago

Okay, seems reasonable. There's only so much fighting I can do with ruby datatypes. :D

anatol commented 6 years ago

Thank you Eli! Your changes look good and they are pushed to master now.