search

anavarre / d9

Quickly install Drupal 9 dev apps with the power of Lando
GNU General Public License v3.0
3 stars 2 forks source link

Run Composer via Lando #3

Closed gitressa closed 4 years ago

gitressa commented 4 years ago

Drupal 9 requires PHP 7.3 or above, but the current code checks the host PHP version, not Lando, since it is run as composer (host OS), and not lando composer (Lando). Originally discussed in #1.

To verify, I downgraded my host OS PHP version to 7.2, and with the updated code, the install goes through fine.

$ lando php -v
PHP 7.3.15 (cli) (built: Feb 26 2020 13:07:10) ( NTS )

$ php -v
PHP 7.2.28-3+ubuntu18.04.1+deb.sury.org+1 (cli) (built: Feb 23 2020 07:23:25) ( NTS )

The patch also changes uri from HTTPS to HTTP.

anavarre commented 4 years ago

Fixed via 9c4619b, but thanks for the contribution!