search

anaynayak / buildnotify

A system tray based build status notification app for cctray.xml feeds.
https://anaynayak.github.io/buildnotify/
Other
29 stars 7 forks source link

support auth tokens in url query parameter #52

Closed MartinNowak closed 4 years ago

MartinNowak commented 6 years ago

ATM only basic auth is supported, but e.g. semaphoreci requires an auth token, thus requiring to store it in plaintext in buildnotify's config. How is this supported by ccmenu et.al.?

If nothing else comes up, I'd suggest some support for string interpolation using e.g. %u, or { user } as placeholders for the username and %p, or { password } as placeholders for the password. Also the URL parser should be fixed to support normal user:pw syntax for basic auth, e.g. https://myuser:mypass@example.com:1234/path?query=val. It seems to simply split on the first colon atm., treating this as port. Once that is fixed, a { user }:{ password }@ prefix could become implicit when a username or password was given, thus preserving the current basic auth scheme.

Presence of { password } in the URL would also signify that a (possibly empty) password is stored in the keyring (also see #51).

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.