Sorry, I introduced a regression in the previous pull request. The truth value of a DataFrame or Series is ambiguous and we really need len() despite what pylint tell us about it. And I did not integrate this in my project to check because it takes a long time. I tried this morning and I got a surprise :)
So I added some tests in order to be able to check fast if the code given in the readme works so it does not happen again. So far we have 80% coverage. But the "customer goods" example of the readme is not working yet. We'll probably have more than that once it is fixed. I get a TypeError: can't multiply sequence by non-int of type 'float'. It's my own call, not Marcomanz's so I was expecting it to not work from the get go. Maybe what is in "revenue" is a string when it should be a float ?
Except for that, everything should be set up, and the badges I added in the Readme should start to show if you sign up to Travis and Coveralls with your github account in order to add pysankey.
Hi,
Sorry, I introduced a regression in the previous pull request. The truth value of a DataFrame or Series is ambiguous and we really need len() despite what pylint tell us about it. And I did not integrate this in my project to check because it takes a long time. I tried this morning and I got a surprise :)
So I added some tests in order to be able to check fast if the code given in the readme works so it does not happen again. So far we have 80% coverage. But the "customer goods" example of the readme is not working yet. We'll probably have more than that once it is fixed. I get a
TypeError: can't multiply sequence by non-int of type 'float'. It's my own call, not Marcomanz's so I was expecting it to not work from the get go. Maybe what is in "revenue" is a string when it should be a float ?Except for that, everything should be set up, and the badges I added in the Readme should start to show if you sign up to Travis and Coveralls with your github account in order to add pysankey.