search

anc95 / ChatGPT-CodeReview

🐥 A code review bot powered by ChatGPT
https://github.com/apps/cr-gpt
ISC License
3.99k stars 386 forks source link

Is the LANGUAGE environment variable working properly? I would like to receive code reviews in Korean. #37

Closed happydeveloper closed 1 year ago

happydeveloper commented 1 year ago

Hi there. Thank you for making such a great app, but I would like to get a code review in Korean. When I looked at the code in the repo, it seems that I can register the LANGUAGE configuration file and process it in the desired language.

But when I test it several times, the code review message is still written in English only.

It would be helpful if the README.md documentation also described how to set the language.

Thanks.

anc95 commented 1 year ago

@happydeveloper you are welcome. what value did you set for the variable LANGUAGE. it's expected to be a human language, You can use Korean in your situation

happydeveloper commented 1 year ago

I have clearly set the environment variable LANGUAGE to Korean as shown in the attached image, but I am still getting responses in English. Does it work in Chinese?

image
anc95 commented 1 year ago

@happydeveloper Sorry, I didn't have a solid test on this. my prompt is in English, but added in the final "Answer me in Korean", but seems it doesn't work from your feedback.

Let me continue working on this feature, to make the prompt itself written in the destination language, this would be better

happydeveloper commented 1 year ago

@anc95 Thanks for creating such a great program, it helps our team a lot in our work. I'd like to take this opportunity to thank you, and I hope you continue to develop it, and I'll close this issue.