search

ancashoria / graphql-kafka-subscriptions

Apollo graphql subscriptions over Kafka protocol
MIT License
187 stars 55 forks source link

Published versions of this package don't seem to include the latest changes #14

Closed rocketraman closed 4 years ago

rocketraman commented 4 years ago

Looking at the commit history of this package, I see for example commit ba8da4f, and then commits to create versions 0.2.5 and 0.2.6. Neither of the latter versions on npm seem to include the code for ba8da4f.

Are you perhaps missing a yarn build step in your publishing steps?

ancashoria commented 4 years ago

Hi @rocketraman I just tested this by doing an npm install and checking the node_modules folder and here's the code in question:

KafkaPubSub.prototype.brokerList = function () {
    return this.options.host.match(',') ? this.options.host : this.options.host + ":" + this.options.port;
};
rocketraman commented 4 years ago

@ancashoria Exactly my point -- that code is not the latest code.

rocketraman commented 4 years ago

Here is the latest code:

https://github.com/ancashoria/graphql-kafka-subscriptions/blob/dfd5c9895a4b2a873194914c76d878c02883c979/src/kafka-pubsub.ts#L85-L87

sjsyrek commented 4 years ago

I would like to bump @rocketraman's comment :)

rodrigopinto commented 4 years ago

We will be releasing a new version soon. @fmannhardt made some improvements on #24 and it is currently merged to the deve branch. We'll improve the documentation as well and get a new version asap. Please bear with me!

fmannhardt commented 4 years ago

I just need to find 1-2 hrs to wraps this up :-)

dfrancoultra commented 4 years ago

I don't want to bother, but do we have an ETA for this?

rodrigopinto commented 4 years ago

Hi @rocketraman and @dfrancoultra, we just release a 0.4.0 version with the most recent changes merge to master. Please try it and let us know in case you find something.

fmannhardt commented 4 years ago

Thanks a lot for taking charge of finally integrating this. I had no time at all for open source stuff the the past months.