search

ancashoria / graphql-kafka-subscriptions

Apollo graphql subscriptions over Kafka protocol
MIT License
187 stars 55 forks source link

fix: allow auto creation of topics #38

Open craicoverflow opened 3 years ago

craicoverflow commented 3 years ago

Currently this engine throws an error if a topic does not exist. This happens within the PubSub library on user application, not in Kafka server).

It is possible to configure topic auto-creation in Kafka with the auto.topic.create.enable flag. However because the validation was happening from this library, it was rejected too early and was never able to be created. This does not respect the Kafka server configuration.

It is much simpler and better to let the Kafka server handle this validation.

nick4fake commented 3 years ago

@ancashoria Could you please merge this PR?