search

anchorchat / anchor-ui

UI kit for chat engines with React
https://ui.anchor.chat
MIT License
21 stars 7 forks source link

withTheme hoc needs a shouldComponentUpdate #481

Closed larstadema closed 7 years ago

larstadema commented 7 years ago

See the following screenshot:

off the 110ms this call took, it took over 20ms to render a withTheme where there were no changes.

screen shot 2017-05-09 at 13 33 58
sjaakluthart commented 7 years ago

485

peterkuiper commented 7 years ago

I'm missing the after screenshot so we can see if it actually had any effect