search

anchore / anchore-charts

Helm charts for Anchore tools and services
http://charts.anchore.io
Apache License 2.0
47 stars 72 forks source link

Enterprise chart doesn't not populate license and imagepullsecrets for feeds chart #361

Closed darrylweaver closed 5 months ago

darrylweaver commented 6 months ago

When deploying the Anchore Enterprise chart it pulls the feeds chart as a dependency.

But the values for the imagePullSecretName and licenseSecretName are not populated into the feeds subchart, failing to pick up a license file/imagepull secret that is not the default name.

As the license file would be common between all components this should be in the global section of the Helm values.

global:
  fullnameOverride: ""
  nameOverride: ""
  imagePullSecretName: anchore-enterprise-pullcreds
  licenseSecretName: anchore-enterprise-license

Imagepullsecret and other parameters in the Common Resource Parameters section should also be considered if they should also be actually global parameters or if they need to be repeated for the feeds service as well.

darrylweaver commented 6 months ago

https://github.com/anchore/anchore-charts/pull/362 - PR to show the change

darrylweaver commented 5 months ago

This will be addressed in the next major release.