search

anchore / anchore-cli

Simple command-line client to the Anchore Engine service
Apache License 2.0
114 stars 55 forks source link

Fix empty content response for manifest/dockerfile/docker_history #78

Closed wagoodman closed 4 years ago

wagoodman commented 4 years ago

Currently anchore-cli image content <img> manifest|dockerfile|docker_history results in no output, this PR addresses this behavior.

alfredodeza commented 4 years ago

This looks OK. At some point we will need to add an image on the functional tests so that doing more involved testing like getting a manifest works and assertions can be added.

alfredodeza commented 4 years ago

I'm adding some functional tests to ensure this doesn't break in the future, let's hold on a bit to get that in, and then merge this if that is OK

alfredodeza commented 4 years ago

@wagoodman can. you review pr #79 and once it merges, rebase from that and take care of the issue that is still present? The dockerfile use case isn't working, and I didn't add tests for docker_history although it does work with your changes.

alfredodeza commented 4 years ago

I'm going to ahead and merge this since pr #79 is taking longer to address. At least this PR fixes a problem and doesn't break anything...