Adds Go and Binary Support For Semantic Version Comparison

anchore / anchore-engine

A service that analyzes docker images and scans for vulnerabilities

Apache License 2.0

1.58k stars 273 forks source link

Adds Go and Binary Support For Semantic Version Comparison #1303

Closed rbrady closed 2 years ago

rbrady commented 2 years ago

A bug was reported where the go language was not supported for version comparison. This patch adds go and binary types to the language version comparison checking.

closes: #ENT-870

Signed-off-by: Ryan Brady ryan.brady@anchore.com

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>)(, fixes #<issue_number, ...) format, will close the issue when PR is merged: fixes #:

Special notes:

rbrady commented 2 years ago

@nightfurys thanks for the review and feedback. I have added the prescribed ValueError with handling/logging and updated the test.

nightfurys commented 2 years ago

@rbrady Since this is targeted for 1.1.0 release, can you edit the base branch of the PR to v1.1.0-dev?