anchore / anchore-engine

A service that analyzes docker images and scans for vulnerabilities
Apache License 2.0
1.58k stars 273 forks source link

Add Almalinux OS support #1326

Closed srbala closed 2 years ago

srbala commented 2 years ago

Followed the changes of https://github.com/anchore/anchore-engine/pull/1315 to provide support for AlmaLinux, resolves #412, in reference to #1299

This PR has dependent PRs in other repos to fulfill https://github.com/anchore/syft/pull/652 https://github.com/anchore/grype/pull/514 https://github.com/anchore/grype-db/pull/40

zhill commented 2 years ago

HI @srbala thanks! We'll take a look at this, but many thanks for the work to put this together!

zhill commented 2 years ago

Looking at this quickly, the window for merge into 1.1.0-dev is closed, so can you change the target of the merge to the master branch instead? We're expecting 1.1.0-dev to release this week, and the next release to be early next year so it will still make it out pretty quickly. Thanks!

srbala commented 2 years ago

@zhill it looks like I have to wait for 1.1.0-dev to merge in master prior to open new PR. https://github.com/anchore/anchore-engine/compare/master...srbala:v1.1.0-dev-add-alma

I might need a rebase of master prior to PR request.

zhill commented 2 years ago

@srbala yes we'll be merging that soon (1.1 just went live!) I don't know if it will strictly require a rebase for a PR, but we can help with that process too.

srbala commented 2 years ago

Replaced by #1337