Closed tri-adam closed 2 months ago
Thanks for making the bump @tri-adam ! I can rebase and merge this later today.
One last note on testing, not sure the best way to do this? I built syft with this version like so: $ go mod edit -replace github.com/anchore/stereoscope=../stereoscope
indeed, that way works well for local testing. Another way is to use go.work
:
# from the syft dir...
go work init
# use "current" dir and "../stereoscope" within the workspace
go work use . ../stereoscope
This has the added benefit of not changing the go.mod
and go.sum
files directly, so is a little easier for local development.
261 pulls in an updated
github.com/sylabs/squashfs
dependency, but unfortunately the v1.0.0 of that has some breaking API changes! I've attempted to address those here, and made some other improvements to the code that backs thesingularity
source. In particular:error
to thefile.Opener
, to be able to explicitly pass an error back when encountered reading a SquashFS file. Let me know if this looks OK... I had to make minor mods in other sources to satisfy that interface, but seems more consistent with how things likego-containerregistry
returnio.ReadCloser
s.uncompressedTarCache
to beuncompressedCache
, and used that on the SquashFS side of things to make sure the code closes file handles everywhere it should.One last note on testing, not sure the best way to do this? I built
syft
with this version like so:And then pulled a SIF image and scanned it:
Let me know if that looks alright, or if there are any other improvements I can make. Thanks!