anchpop / wise_mans_haskell

Free book for learning Haskell
https://andre.tips/wmh/
48 stars 5 forks source link

Do notation section #1

Closed FayeAlephNil closed 5 years ago

FayeAlephNil commented 5 years ago

spongebobDo.hs does not actually use do notation, which is rather confusing in reading. Likewise, goodDo.hs uses return whereas the book uses pure, and it includes the error comment when it doesn't actually error

anchpop commented 5 years ago

Thanks! These issues should be fixed now

On Sat, Oct 27, 2018 at 8:54 PM Strikingwolf notifications@github.com wrote:

spongebobDo.hs https://github.com/anchpop/wise_mans_haskell/blob/master/haskelltests/should_compile/spongebobDo.hs does not actually use do notation, which is rather confusing in reading. Likewise, goodDo.hs https://github.com/anchpop/wise_mans_haskell/blob/master/haskelltests/should_compile/goodDo.hs uses return whereas the book uses pure, and it includes the error comment when it doesn't actually error

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/anchpop/wise_mans_haskell/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/ADigR6wIqdlRgR-E30gWmuJG9eJLN9WGks5upQArgaJpZM4X9uQO .