ancientmc / AncientCoderPack

[WIP] Buildable gradle of older MC versions inspired by the Mod Coder Pack.
Other
3 stars 0 forks source link

Messing with this but having issues. #1

Open AidenManuel opened 3 months ago

AidenManuel commented 3 months ago

Hey ACP Developer,

So I've been trying to get this working for a little while now, because I wanna try modding Alpha 1.2.6, but this is my first ever modding experience so I'm working from nothing. I've managed to get ACP running, using the setup task (this is also my first time using Gradle), and it seems to start off fine, but then it runs into an issue. The issue specifically apparently has to do with the task ':AncientCoderPack:copyJarAssets', according to Gradle. The reason provided is as follows:

Reason: Task ':AncientCoderPack:copyJarAssets' uses this output of task ':AncientCoderPack:downloadJar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.

It suggests the following solutions, although I'm not super sure how to implement them or what they would change:

Possible solutions:

  1. Declare task ':AncientCoderPack:downloadJar' as an input of ':AncientCoderPack:copyJarAssets'.
  2. Declare an explicit dependency on ':AncientCoderPack:downloadJar' from ':AncientCoderPack:copyJarAssets' using Task#dependsOn.
  3. Declare an explicit dependency on ':AncientCoderPack:downloadJar' from ':AncientCoderPack:copyJarAssets' using Task#mustRunAfter.

Interestingly, when I run the runClient task, it does actually run... something. A window opens up, labelled minecraft, but it doesn't seem like anything is rendering. I think it may be because the resources folder in src\main\ is empty, but I could be way off as I've never seen the decompiled Minecraft code before.

image example of the running application

Hopefully you can help me out, and let me know if this is a me problem or something that needs to be changed. If you have any suggestions for me to try, I'd be happy to give them a whirl. Like I said, I'm super new to this process, so I could have it all backwards and it could be something silly.

Cheers, Aiden

moist-mason commented 3 months ago

@AidenManuel Hi there! I'm the dev behind ACP.

I'm assuming you're using the 0.1.2 release? I believe I know the cause of the issue, but I'd have to look at the plugin code (you can see it here). I don't have access to my laptop at this moment, but I'll look at it tonight, though it might take a couple of days before I can commit and publish anything.

In the meantime, I'd encourage you to mess around with the 0.2.0-beta branch. It's a WIP, and I need to commit some updates to the plugin and upload the updated JAR to the maven. But it's much tighter than the old releases, and has some support for the old pre-Forge mod loader.

Thanks for checking ACP out, I've been away from programming for a while so it's been somewhat dormant. But I started getting back into coding recently, and I'm glad people are taking interest in my stuff. I hope you can get good use out of it :)

Thanks,

Mason

moist-mason commented 3 months ago

@AidenManuel Hi Aiden,

I tried replicating the issue, and while I saw a similar warning message about the copyJarAssets task in the console, it wasn't an error for me and the setup finished without any problem. Not sure what's causing the discrepancy between our setups. Regardless, I've updated the gradle plugin (and this repo) to address the issue. From my testing the message went away, so it seems fine.

Please clone the repo (or download the code as a zip), test it out, and report here if the error still happens or if I still need to do some tweaking.

Thank you!

Mason

moist-mason commented 3 months ago

@AidenManuel Hi Aiden, sorry for the notification.

I have released a pre-release to address this issue. Please let me know if the issue has been solved for you or if it persists. Thanks.

Mason