Bug in model_utils.degree_correlation

ancklo / ChaosMagPy

ChaosMagPy is a simple Python package for evaluating the CHAOS geomagnetic field model and other models of Earth's magnetic field.

Other

23 stars 3 forks source link

Closed smithara closed 5 years ago

smithara commented 5 years ago

Two minor things that prevent it from running:

Change value checking to len(coeffs_1) != len(coeffs_2) in place of is not
nmax needs to be forced to be int, nmax = int(np.sqrt(len(coeffs_1) + 1) - 1) I haven't tested it otherwise but it looks right

Btw, thanks for providing the library, it's been useful to me :)

ancklo commented 5 years ago

Thanks for pointing this out, you're completely right :) I implemented the suggested changes. You can get an updated version from PyPI now.

I'm happy to hear that it's useful. Please let me know if you encounter more bugs, feedback is very welcome :D