search

anclrii / Storj-Exporter

Prometheus exporter for monitoring Storj storage nodes
GNU General Public License v3.0
59 stars 19 forks source link

Use url for sattelite name in metrics #25

Closed mk-dhia closed 4 years ago

mk-dhia commented 4 years ago

more user freindly than id

anclrii commented 4 years ago

Since https://github.com/anclrii/Storj-Exporter/pull/25 and https://github.com/anclrii/Storj-Exporter/pull/22 are closely related I was looking for a consistent way to make them both work together. Since I ended up with a working code in the process I'm raising https://github.com/anclrii/Storj-Exporter/pull/26 for review. Also I decided to keep sat id label and add url label to it to keep compatibility. Can you please check https://github.com/anclrii/Storj-Exporter/pull/26 and let me know if you're happy with the change?