search

anclrii / Storj-Exporter

Prometheus exporter for monitoring Storj storage nodes
GNU General Public License v3.0
58 stars 19 forks source link

Remove LastPinged information from storj_node_info #56

Closed kevinkk525 closed 2 years ago

kevinkk525 commented 3 years ago

Can we remove the LastPinged information from storj_node_info? It clutters the metric horribly with (in my opinion) no relevant information. Where is the lastPinged information even useful? And if it really is, can't we change it to a normal metric?

https://github.com/anclrii/Storj-Exporter/blob/fe5dba595ee15ab9a53afc8922e10848d7edefd8/storj-exporter.py#L82

anclrii commented 3 years ago

I had my doubts when adding this one, there's a few others that don't make much sense I think and a few that are duplicate values fetched from different parts of api. I was just adding everything available though and wasn't sure what's going to end up on the dashboards.

Let's clarify the use-case for LastPinged maybe before we remove it?

kevinkk525 commented 3 years ago

Well theoretically lastPinged can be used to detect if the node is offline. But I haven't really found a good way to work with labels in grafana so for alerting and calculations it would need to be the value of a metric and not the value of a label. I would have no problem keeping it as a normal metric as it just stores an ever increasing timestamp. Haven't checked in grafana if you can make a graph that alerts you if it doesn't change for a certain period though..

anclrii commented 2 years ago

Removed in https://github.com/anclrii/Storj-Exporter/pull/65