search

anclrii / Storj-Exporter

Prometheus exporter for monitoring Storj storage nodes
GNU General Public License v3.0
59 stars 19 forks source link

Added quicStatus to Info Metrics #73

Closed GollyTicker closed 1 year ago

GollyTicker commented 1 year ago

I added quicStatus so that we can also see them on the grafana dashboards.

Original Storj Dashboard

image

JSON

$ curl -s http://localhost:14002/api/sno/ | jq '.quicStatus'
"OK"

I wanted to extend the tests to cover this case. But I didn't manage to successfully reproduce the tests. (I got errors with a simple pytest -v tests.)

What do you think about this? Would you like to merge this?

You can add tests, if you want to.

This is a duplicate of this older PR: https://github.com/anclrii/Storj-Exporter/pull/72 I created this new PR, as I added changes to master which I didn't want to merge.

anclrii commented 1 year ago

Hi @GollyTicker, LGTM, merging thanks! Let me know if you'd want to update the tests and I can share some hints also (need to refresh api_mock with record-api.sh etc).

anclrii commented 1 year ago

I found CI was also broken so I fixed that and updated the tests here https://github.com/anclrii/Storj-Exporter/pull/74, thanks again.

GollyTicker commented 1 year ago

Thanks for merging and updating the tests!