search

ancwrd1 / snx-rs

Open source Linux client for Checkpoint VPN tunnels
GNU Affero General Public License v3.0
57 stars 5 forks source link

Fix password prompt for no-keychain and fix infinite challenge requests with no-keychain #10

Closed nut-3 closed 4 months ago

nut-3 commented 4 months ago

Hi again. This PR addresses several issues that I've faced since 0.10.0 release.

  1. Commit 65b124f2e8cc8925e04ba7d154306f167033f5f5 fixes absence of password prompt in case of 'no-keychain' usage. Without it, snx-rs sends first request without password and then proceeds with CommandServer::challenge_code() logic.
  2. Commit 00f99f5c96159ed7928ad34455663f14cea1629c addresses incorrect connection status check after SSL tunnel set up. Without it I get an extra password prompts from CommandServer::challenge_code() and an error:
    • Before: image
    • After: image This does not happen when using Ipsec tunnel though...
  3. Commit 216eb8123378366a749efbfad8c85067fc12927c adds fancy password prompt for standalone mode.
  4. Last commit fixes regression of #8 fix. Don't know why, but trim in quoted string deserialization just stopped working.
nut-3 commented 4 months ago

@ancwrd1 could you make a release with these changes, pls?

ancwrd1 commented 4 months ago

Yes, added.