Resolve usage of `useSelector`

[tomdownes14]

In GitLab by @tom.downes on Feb 28, 2024, 09:16

Summary

Our usage of useSelector, or in our case useAppSelector, uses the entire state object. This is non performant and highly discouraged.

A warning is generated in new versions of react-redux:

Selector unknown returned the root state when called. This can lead to unnecessary rerenders.
Selectors that return the entire state are almost certainly a mistake, as they will cause a rerender whenever *anything* in state changes.

Benefits

More performant usage of react-redux and no more warnings.

Possible Solution and Impacts

• Update our usage and any related tests
• Tests will require rework where they rely upon spy/mock of useAppSelector

Are all areas of the checklist addressed?

• [ ] Are Functions Impacted?
• [ ] Feature Flag Decision Made?
• [ ] Database Changes?
• [ ] What roles can access this feature?
• [ ] Testing Strategy

[tomdownes14]

In GitLab by @tom.downes on Feb 28, 2024, 14:28

created branch 334-resolve-usage-of-useselector to address this issue