search

and-rej / rotate-and-zoom-image

Is there a picture with wrong orientation, or just displayed too small? Rotate or zoom images directly on any website, just one in the context menu.
https://addons.mozilla.org/firefox/addon/rotate-and-zoom-image/
Mozilla Public License 2.0
16 stars 2 forks source link

Missfunction of zooming #27

Closed mdziczkowski closed 4 years ago

mdziczkowski commented 5 years ago

I want to report that while zooming in, the image is beeeing cut-off in some parts (aspecially from the top and/or bottom) and it's restored while using the "reset" function. Please fix it asap because it makes hard to enjoy the pics while they are cropped and unable to scroll

MikkCZ commented 5 years ago

Hi Michal.

Can you please send me a link of a specific page + which specific picture on that page, where I could reproduce it? If possible, accessible without registration or login.

Thank you

mdziczkowski commented 5 years ago

This happens on most of images I try to zoom in, independant from the page on with I try to do it 

    Dnia 29 października 2019 11:00 Michal Stanke <notifications@github.com> napisał(a):

     Hi Michal.

Can you please send me a link of a specific page + which specific picture on that page, where I could reproduce it? If possible, accessible without registration or login. Thank you

— You are receiving this because you authored the thread. Reply to this email directly, github.com view it on GitHub , or github.com unsubscribe .

MikkCZ commented 5 years ago

Hi Michał.

The only way I was able to reproduce is when the images have some parent that is limiting the ability of the images to overflow. An example are preview images on the cnn.com homepage for example.

Unfortunately I don't know a straightforward way to tackle this, if the add-on should. Actually the only thing this extension does is to apply some basic CSS rules for the image and the rest of the page is not adjusted for it in any way.

If you have an idea to solve this issue, I will be happy to implement it. As I am not using the extension, I haven't updated it for almost 2 years, so there are definitely ways to do things better.

mdziczkowski commented 5 years ago

it's strange that the images are cropped just one sided for the time of zoom in and the cropping is undone when clicking the "reset" position from the context sub-menu. Maybe you could try find out why it's cropped only on one side (usually top or bottom) and use the same rule from the unaffected side for the cropping one. ~Michal 

    Dnia 30 października 2019 14:40 Michal Stanke <notifications@github.com> napisał(a):

     Hi Michał.

The only way I was able to reproduce is when the images have some parent that is limiting the ability of the images to overflow. An example are preview images on the cnn.com homepage for example. Unfortunately I don't know a straightforward way to tackle this, if the add-on should. Actually the only thing this extension does is to apply some basic CSS rules for the image and the rest of the page is not adjusted for it in any way. If you have an idea to solve this issue, I will be happy to implement it. As I am not using the extension, I haven't updated it for almost 2 years, so there are definitely ways to do things better.

— You are receiving this because you authored the thread. Reply to this email directly, github.com view it on GitHub , or github.com unsubscribe .