search

and-rej / rotate-and-zoom-image

Is there a picture with wrong orientation, or just displayed too small? Rotate or zoom images directly on any website, just one in the context menu.
https://addons.mozilla.org/firefox/addon/rotate-and-zoom-image/
Mozilla Public License 2.0
16 stars 2 forks source link

Does not work on images with links #3

Closed MikkCZ closed 7 years ago

MikkCZ commented 7 years ago

Seems it does not work on images with links (so far I have noticed this directly on AMO, when trying to rotate the Firefox logo in the header). The possible cause is here, when the variable may got assigned to null by a subsequent call for the link context menu. I will need to verify first.

Having a shared variable is not a nice pattern in any case, but I do not see any obvious way to encapsulate it e.g. in an object instance at this moment. Maybe keeping a table of context menus opened for the document + the clicked images, and sending some ID back with the message...

MikkCZ commented 7 years ago

OK, this is actually not a bug and happens on AMO only. Seems AMO is blocking content scripts.