search

and3rson / clay

Awesome standalone command line player for Google Play Music.
GNU General Public License v3.0
157 stars 11 forks source link

The existence of python-dbus does not imply the existence of notifications #37

Open agg23 opened 5 years ago

agg23 commented 5 years ago

From osd.py:

try:
    from dbus import SessionBus, Interface
    IS_INIT = True
except ImportError:
    ERROR_MESSAGE = 'Could not import dbus. OSD notifications will be disabled.'

This resulted in a crash on a barebones environment that does not have a notification system set up, but happened to have the dbus package installed.

ValentijnvdBeek commented 5 years ago

Hello agg,

First of all, thanks a lot for reporting and recommending a fix for these bugs. I do rather appreciate it.

However, I am sad to say that both of these bugs are either already fixed in the porcelain branch or those specific parts of the code have been rewritten (e.x. we now use pydbus). So for that reason I am going close both merge requests.

Sorry for not communicating that better.

agg23 commented 5 years ago

No problem. Just wanted to make clay usable for me. I'll probably be playing with it more and submitting changes (that you might or might not like) in the near future.

ValentijnvdBeek commented 5 years ago

Any changes would be great.

Also, it might be a good idea to work on the Porcelain branch instead since it changes a crazy amount of stuff and merging changes to the master branch back into is going to be major pain.

I am also reopening the issue itself since it is valid.