search

and3rson / clay

Awesome standalone command line player for Google Play Music.
GNU General Public License v3.0
157 stars 11 forks source link

Add playcount incrementation. #49

Closed vale981 closed 5 years ago

vale981 commented 6 years ago

I've added this to keep gmusic stats on track and in the hope, that the artists get paid if the play count increases.

vale981 commented 6 years ago

Hey folks. Thanks for the interest :).

This request was only meant as a proposal (because it's just a dirty hack) so I have absolutely no problems modifying it according to the change requests :)

Cheers.

vale981 commented 6 years ago

I've squashed the commits and made the increment_placount method async. The optional callback seems to me as the sanest option for the use case

The wrapper in gp could be extended to the full functionality from gmusicapi but for now, I saw no reason to do that.

One could add some more advanced metrics for the playcount incrementation (like a threshold playtime).

Cheers.

ValentijnvdBeek commented 6 years ago

Could you squash the commit?

ValentijnvdBeek commented 5 years ago

@vale981 I just applied the patches to the development branch with a few changes (made checking callback for None more global and changed the documentation.) Do you agree with this since your name is on it.

vale981 commented 5 years ago

Absolutely!

ValentijnvdBeek commented 5 years ago

Alright, then I am closing this merge request now.

By the way, I somewhat enjoy the fact that, when you translate it English, that commit it says: authored by Valentine, signed off by Valentine. Beautiful.