andabi / deep-voice-conversion

Deep neural networks for voice conversion (voice style transfer) in Tensorflow
MIT License
3.92k stars 845 forks source link

removed a literal comparison pitfall case #133

Open NaelsonDouglas opened 3 years ago

NaelsonDouglas commented 3 years ago

The problem In Python when comparing to non-singleton values, it advised to use the operator '==' instead of 'is'. By doing otherwise, we may fall into the a code pitfall which can be detected by pylint under the identification of R0123 literal-comparison https://vald-phoenix.github.io/pylint-errors/plerr/errors/basic/R0123.html

The solution Refactored the comparisons on literals